Where is your source that suicide is a crime in all 50 states?
In the past there were states that had laws against suicide but currently there are no laws against the act of committing suicide in the United States. There have been cases where suicide is considered a common law crime unless the victim was proven to be "unsound mind."
http://mentalhealthdaily.com/2014/07...ws-by-country/
Suicide is treated as a mental health issue. It's very rare - if it even happens at all anymore - that someone is arrested and charged for attempted suicide. If someone is successful in killing themselves who would you charge if it is illegal? The family could be denied survivor benefits. The military doesn't even do that though anymore for suicides. I do know that I saw a story about a servicemember who attempted suicide and his command used UCMJ against him. I don't remember what happened with it. But in the civilian world - no. Suicide is not illegal.
Assisted suicide is illegal in many states.

